steveloughran commented on a change in pull request #802: HADOOP-16279.
S3Guard: Implement time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#discussion_r289510995
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java
##########
@@ -147,10 +149,10 @@ public static MetadataStore getMetadataStore(FileSystem
fs)
*/
@RetryTranslated
public static S3AFileStatus putAndReturn(MetadataStore ms,
- S3AFileStatus status,
- S3AInstrumentation instrumentation) throws IOException {
+ S3AFileStatus status, S3AInstrumentation instrumentation,
+ ITtlTimeProvider timeProvider) throws IOException {
Review comment:
nit; once you go one arg per line (it scales well), don't merge back
again...so put instrumentation back on its own line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
