xiaoyuyao commented on a change in pull request #857: HDDS-1600. Add userName
and IPAddress as part of OMRequest.
URL: https://github.com/apache/hadoop/pull/857#discussion_r289541640
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##########
@@ -114,13 +116,19 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
OzoneManagerProtocolProtos.Type.CreateBucket).setStatus(
OzoneManagerProtocolProtos.Status.OK);
- OmBucketInfo omBucketInfo = null;
-
+ OmBucketInfo omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
- metadataManager.getLock().acquireVolumeLock(volumeName);
- metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
try {
+ // check Acl
+ if (ozoneManager.getAclsEnabled()) {
+ checkAcls(ozoneManager, OzoneObj.ResourceType.BUCKET,
+ OzoneObj.StoreType.OZONE, IAccessAuthorizer.ACLType.CREATE,
+ volumeName, bucketName, null);
+ }
+
+ metadataManager.getLock().acquireVolumeLock(volumeName);
Review comment:
I think the right lock pattern is to acquire lock out of try {} block and
release them in the final block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
