bharatviswa504 commented on a change in pull request #857: HDDS-1600. Add
userName and IPAddress as part of OMRequest.
URL: https://github.com/apache/hadoop/pull/857#discussion_r289543238
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java
##########
@@ -69,15 +65,21 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
String volumeName = omRequest.getDeleteBucketRequest().getVolumeName();
String bucketName = omRequest.getDeleteBucketRequest().getBucketName();
- // acquire lock
- omMetadataManager.getLock().acquireBucketLock(volumeName, bucketName);
-
// Generate end user response
OMResponse.Builder omResponse = OMResponse.newBuilder()
.setStatus(OzoneManagerProtocolProtos.Status.OK)
.setCmdType(omRequest.getCmdType());
try {
+ // check Acl
+ if (ozoneManager.getAclsEnabled()) {
+ checkAcls(ozoneManager, OzoneObj.ResourceType.BUCKET,
Review comment:
Right now lock manager does not have readlock acquire on bucket. Do you mean
acquire bucket lock?
And why do we need to acquire lock here? I don't see for any requests
acquire of lock in current OzoneManager.java code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
