hadoop-yetus commented on issue #881: YARN-2774. support secure clusters in 
shared cache manager
URL: https://github.com/apache/hadoop/pull/881#issuecomment-497901456
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 25 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 3 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 24 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1122 | trunk passed |
   | +1 | compile | 1046 | trunk passed |
   | +1 | checkstyle | 147 | trunk passed |
   | +1 | mvnsite | 251 | trunk passed |
   | +1 | shadedclient | 1168 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 220 | trunk passed |
   | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 458 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 48 | Maven dependency ordering for patch |
   | +1 | mvninstall | 169 | the patch passed |
   | -1 | compile | 1344 | root in the patch failed. |
   | -1 | javac | 1344 | root in the patch failed. |
   | -0 | checkstyle | 145 | root: The patch generated 4 new + 244 unchanged - 
3 fixed = 248 total (was 247) |
   | +1 | mvnsite | 244 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 705 | patch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 194 | the patch passed |
   | -1 | findbugs | 54 | 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager
 generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 539 | hadoop-common in the patch passed. |
   | +1 | unit | 52 | hadoop-yarn-api in the patch passed. |
   | +1 | unit | 227 | hadoop-yarn-common in the patch passed. |
   | +1 | unit | 163 | hadoop-yarn-server-common in the patch passed. |
   | +1 | unit | 48 | hadoop-yarn-server-sharedcachemanager in the patch 
passed. |
   | +1 | asflicense | 40 | The patch does not generate ASF License warnings. |
   | | | 8791 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager
 |
   |  |  Possible doublecheck on 
org.apache.hadoop.yarn.server.sharedcachemanager.security.SCMPolicyProvider.scmPolicyProvider
 in 
org.apache.hadoop.yarn.server.sharedcachemanager.security.SCMPolicyProvider.getInstance()
  At 
SCMPolicyProvider.java:org.apache.hadoop.yarn.server.sharedcachemanager.security.SCMPolicyProvider.getInstance()
  At SCMPolicyProvider.java:[lines 42-44] |
   |  |  
org.apache.hadoop.yarn.server.sharedcachemanager.security.SCMPolicyProvider.getServices()
 may expose internal representation by returning SCMPolicyProvider.SCM_SERVICES 
 At SCMPolicyProvider.java:by returning SCMPolicyProvider.SCM_SERVICES  At 
SCMPolicyProvider.java:[line 66] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/881 |
   | Optional Tests | dupname asflicense mvnsite compile javac javadoc 
mvninstall unit shadedclient findbugs checkstyle xml |
   | uname | Linux 0846ea1187a6 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed 
Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c1d2d92 |
   | Default Java | 1.8.0_212 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/artifact/out/patch-compile-root.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/artifact/out/patch-compile-root.txt
 |
   | checkstyle | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/artifact/out/diff-checkstyle-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.html
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/testReport/ |
   | Max. process+thread count | 1344 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager
 U: . |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-881/5/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to