[ 
https://issues.apache.org/jira/browse/HADOOP-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066800#comment-13066800
 ] 

Uma Maheswara Rao G commented on HADOOP-4048:
---------------------------------------------

{code}
// clean up all calls
      if (closeException == null) {
        if (!calls.isEmpty()) {
          LOG.warn(
              "A connection is closed for no cause and calls are not empty");

          // clean up calls anyway
          closeException = new IOException("Unexpected closed connection");
          cleanupCalls();
        }
      } else {
        // log the info
        if (LOG.isDebugEnabled()) {
          LOG.debug("closing ipc connection to " + server + ": " +
              closeException.getMessage(),closeException);
        }

        // cleanup calls
        cleanupCalls();
      }
{code}

In Trunk, when closing the client, this is the peice of code will execute.

You mean, we can add the log in else part also when the calls are not empty?

> ipc.Client:  Log when Server side closes the socket while request is still 
> pending
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4048
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Koji Noguchi
>            Priority: Minor
>
> ipc/Client.java
> {noformat}
> 316       } catch (EOFException eof) {
> 317         // This is what happens when the remote side goes down
> 318       } 
> {noformat}
> Request to log  when Server side closes the socket while some requests are 
> still pending.
> This would have helped when debugging HADOOP-4040.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to