bgaborg commented on a change in pull request #879: HADOOP-15563 Full S3Guard 
Support for on-demand DDB tables
URL: https://github.com/apache/hadoop/pull/879#discussion_r289776605
 
 

 ##########
 File path: 
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
 ##########
 @@ -274,7 +300,9 @@ public void testInitialize() throws IOException {
         getTestTableName("testInitialize");
     final Configuration conf = s3afs.getConf();
     conf.set(S3GUARD_DDB_TABLE_NAME_KEY, tableName);
-    try (DynamoDBMetadataStore ddbms = new DynamoDBMetadataStore()) {
+    enableOnDemand(conf);
 
 Review comment:
   You add this in @BeforeClass as well. Is there a point to add this to all 
tests as well? Maybe add this to `@Before` only?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to