anuengineer commented on a change in pull request #882: HDDS-1624 : Refactor
operations inside the bucket lock in OM key write.
URL: https://github.com/apache/hadoop/pull/882#discussion_r290137419
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/RDBTable.java
##########
@@ -119,6 +119,16 @@ public boolean isEmpty() throws IOException {
}
}
+ @Override
+ public boolean isExist(byte[] key) throws IOException {
+ try {
+ return db.get(handle, key) != null;
+ } catch (RocksDBException e) {
+ throw toIOException(
+ "Failed to check if given key exists", e);
Review comment:
This error message is kind of confusing. Perhaps replace it with, "Error in
accessing DB.".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
