bgaborg commented on a change in pull request #802: HADOOP-16279. S3Guard:
Implement time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#discussion_r290196583
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/MetadataStore.java
##########
@@ -63,14 +63,19 @@
* Deletes exactly one path, leaving a tombstone to prevent lingering,
* inconsistent copies of it from being listed.
*
+ * Deleting an entry with a tombstone needs a
+ * {@link org.apache.hadoop.fs.s3a.s3guard.S3Guard.TtlTimeProvider} because
+ * the lastUpdated field of the record has to be updated to <pre>now</pre>.
+ *
* @param path the path to delete
+ * @param ttlTimeProvider
* @throws IOException if there is an error
*/
- void delete(Path path) throws IOException;
+ void delete(Path path, ITtlTimeProvider ttlTimeProvider) throws IOException;
Review comment:
Iff you delete with tombstones it should not be not null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
