steveloughran commented on a change in pull request #879: HADOOP-15563 S3Guard
to create on-demand DDB tables
URL: https://github.com/apache/hadoop/pull/879#discussion_r290832301
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
##########
@@ -274,7 +300,9 @@ public void testInitialize() throws IOException {
getTestTableName("testInitialize");
final Configuration conf = s3afs.getConf();
conf.set(S3GUARD_DDB_TABLE_NAME_KEY, tableName);
- try (DynamoDBMetadataStore ddbms = new DynamoDBMetadataStore()) {
+ enableOnDemand(conf);
Review comment:
it's done in the beforeClass for the static table; for the others its done
to to the config which comes from the FS.
I'm going to change it to set it in the FS config before we set the FS. If
someone has per-bucket options to set the capacity then things will be
different, but I'd be surprised if anyone ever does that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
