hanishakoneru commented on a change in pull request #877: HDDS-1618. Merge code for HA and Non-HA OM write type requests for bucket URL: https://github.com/apache/hadoop/pull/877#discussion_r290495002
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java ########## @@ -52,6 +54,10 @@ private final RequestHandler handler; private final boolean isRatisEnabled; private final OzoneManager ozoneManager; + private final OMMetadataManager omMetadataManager; + // Used during Non-HA when calling validateAndUpdateCache methods in + // OMClientRequest. As in Non-HA with out ratis, we don't use this. Review comment: Comment is contradictory. Do we use it during HA or non-HA? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
