xiaoyuyao edited a comment on issue #903: HDDS-1490. Support configurable 
container placement policy through 'o…
URL: https://github.com/apache/hadoop/pull/903#issuecomment-499196069
 
 
   bq. Cannot mock/spy class org.apache.hadoop.ozone.om.OzoneManager
   Mockito cannot mock/spy because :final class
   
   I think this is related to the change in the pom.xml
   As seen in the screen snapshot: ![Screen Shot 2019-06-05 at 11 16 43 
AM](https://user-images.githubusercontent.com/7039184/58979837-cbbae700-8783-11e9-9159-6161593c85ba.png)
   
   we only add the topology related xml files to testResources explicitly, but 
the mokito-extensions from the test/resources is missing, which is need to 
surpress the warning above. I believe if we add the following to the pom should 
fix the issue above.
   
        <testResource>
          <directory>${basedir}/src/test/resources</directory>
        </testResource>
   
   Also, please fix the checkstyle issue in the next commit. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to