bharatviswa504 commented on a change in pull request #703: HDDS-1371. Download
RocksDB checkpoint from OM Leader to Follower.
URL: https://github.com/apache/hadoop/pull/703#discussion_r290886074
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -536,14 +535,6 @@ private void setOMNodeDetails(String serviceId, String
nodeId,
configuration.set(OZONE_OM_ADDRESS_KEY,
NetUtils.getHostPortString(rpcAddress));
- // Find the Ratis storage dir
- String omRatisDirectory = OmUtils.getOMRatisDirectory(configuration);
- if (omRatisDirectory == null || omRatisDirectory.isEmpty()) {
- throw new IllegalArgumentException(HddsConfigKeys.OZONE_METADATA_DIRS +
- " must be defined.");
- }
-
- omRatisStorageDir = OmUtils.createOMDir(omRatisDirectory);
Review comment:
Why this code is completely removed, now ratis Storage creation/ check is
done in a different place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]