bharatviswa504 commented on a change in pull request #804: HDDS-1496. Support
partial chunk reads and checksum verification
URL: https://github.com/apache/hadoop/pull/804#discussion_r290956283
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkInputStream.java
##########
@@ -346,28 +349,34 @@ protected ByteString readChunk(ChunkInfo readChunkInfo)
throws IOException {
private CheckedBiFunction<ContainerCommandRequestProto,
ContainerCommandResponseProto, IOException> validator =
- (request, response) -> {
- final ChunkInfo chunkInfo = request.getReadChunk().getChunkData();
-
- ReadChunkResponseProto readChunkResponse = response.getReadChunk();
- ByteString byteString = readChunkResponse.getData();
-
- if (byteString.size() != chunkInfo.getLen()) {
- // Bytes read from chunk should be equal to chunk size.
- throw new OzoneChecksumException(String
- .format("Inconsistent read for chunk=%s len=%d bytesRead=%d",
- chunkInfo.getChunkName(), chunkInfo.getLen(),
- byteString.size()));
- }
-
- if (verifyChecksum) {
- ChecksumData checksumData =
- ChecksumData.getFromProtoBuf(chunkInfo.getChecksumData());
- int checkumStartIndex =
- (int) (bufferOffset / checksumData.getBytesPerChecksum());
- Checksum.verifyChecksum(byteString, checksumData, checkumStartIndex);
- }
- };
+ (request, response) -> {
+ final ChunkInfo reqChunkInfo =
+ request.getReadChunk().getChunkData();
+
+ ReadChunkResponseProto readChunkResponse = response.getReadChunk();
+ ByteString byteString = readChunkResponse.getData();
+
+ if (byteString.size() != reqChunkInfo.getLen()) {
+ // Bytes read from chunk should be equal to chunk size.
+ throw new OzoneChecksumException(String
+ .format("Inconsistent read for chunk=%s len=%d bytesRead=%d",
+ reqChunkInfo.getChunkName(), reqChunkInfo.getLen(),
+ byteString.size()));
+ }
+
+ if (verifyChecksum) {
+ ChecksumData checksumData = ChecksumData.getFromProtoBuf(
+ chunkInfo.getChecksumData());
+
+ // ChecksumData stores checksum for each 'numBytesPerChceksum'
Review comment:
Typo. numBytesPerChceksum -> numBytesPerChecksum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
