steveloughran commented on a change in pull request #802: HADOOP-16279.
S3Guard: Implement time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#discussion_r291167893
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java
##########
@@ -534,12 +530,18 @@ public TtlTimeProvider(long authoritativeDirTtl) {
this.authoritativeDirTtl = authoritativeDirTtl;
}
+ public TtlTimeProvider(Configuration conf) {
+ this.authoritativeDirTtl =
Review comment:
Switch to Configuration.getTimeDuration(). Also, I think we should make the
default time seconds, not millis. Just because our internal clocks are millis
doesn't mean it makes a good configuration parameter for something which should
always be measured in seconds. And if they want to switch to millis, that call
makes it easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
