[ 
https://issues.apache.org/jira/browse/HADOOP-16353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858595#comment-16858595
 ] 

Steve Loughran edited comment on HADOOP-16353 at 6/7/19 2:14 PM:
-----------------------------------------------------------------

Generated markdown log of all commits which I plan to backport.

I've been doing backport games elsewhere, and Propose the following strategy

# create a branch for this
# merge, compile and unit test each one
# intermittently integration test (probably every second one, plus everything 
where there was merge conflict)
# submit as a final PR for review, with full integration tests
# ignore checkstyle issues where the code in question matches 100% trunk
# fix findbugs issues
# once yetus is happy, merge commit the branch. 

All the patches are already in trunk, so backporting individual patches doesn't 
need a vote. I'm just doing this in a way which is methodical

{code}

| Hash         | Date                      | Commit message | Author | 
Committer | 
|--------------|---------------------------|----------------|--------|-----------|
|  bd50fa956b1 | 2018-10-09 20:02:12 +0100 | HADOOP-15825. ABFS: Enable some 
tests for namespace not enabled account using OAuth. Contributed by Da Zhou. | 
Steve Loughran | Steve Loughran |              
|  ef9dc6c44c6 | 2018-10-15 22:53:55 +0100 | HADOOP-15851. Disable wildfly logs 
to the console. Contributed by Vishwajeet Dusane. | Steve Loughran | Steve 
Loughran |                                      
|  e374584479b | 2018-10-24 14:18:35 -0700 | HADOOP-15823. ABFS: Stop requiring 
client ID and tenant ID for MSI (Contributed by Da Zhou via Daniel Templeton) | 
Daniel Templeton | Daniel Templeton |      
|  13f0ee21f2c | 2019-01-02 09:33:09 -0700 | HADOOP-15860. ABFS: Throw 
exception when directory / file name ends with a period (.). Contributed by 
Shweta Yakkali. | Sean Mackrory | Sean Mackrory |       
|  65f60e56b08 | 2019-02-28 14:22:32 +0000 | HADOOP-16068. ABFS Authentication 
and Delegation Token plugins to optionally be bound to specific URI of the 
store. | Steve Loughran | Steve Loughran |       
|  05df151d09b | 2019-03-05 14:02:34 +0000 | HADOOP-16163. NPE in 
setup/teardown of ITestAbfsDelegationTokens. | Da Zhou  | Steve Loughran |      
                                                         
|  bb8ad096e78 | 2019-03-09 09:55:56 -0800 | HADOOP-16157. [Clean-up] Remove 
NULL check before instanceof in AzureNativeFileSystemStore (Contributed by 
Shweta Yakkali via Daniel Templeton) | Shweta Yakka
|  ddede7ae6fb | 2019-03-09 18:45:17 +0000 | HADOOP-16174. Disable wildfly logs 
to the console. | Denes Gerencser | Steve Loughran |                            
                                           
|  1edf1914acb | 2019-03-18 13:18:08 +0000 | HADOOP-16182. Update abfs storage 
back-end with "close" flag when application is done writing to a file. | 
Vishwajeet Dusane | Steve Loughran |               
|  1cef194a280 | 2019-04-29 13:27:28 +0100 | HADOOP-16242. ABFS: add bufferpool 
to AbfsOutputStream. | Da Zhou  | Steve Loughran |                              
                                           
|  ff27e8eabde | 2019-05-10 13:57:30 -0700 | HADOOP-16251. ABFS: add 
FSMainOperationsBaseTest. Re-commit to fix git metadata. | DadanielZ | Aaron 
Fabbri |                                                 
{code}


was (Author: [email protected]):
Generated markdown log of all commits which I plan to backport.

I've been doing backport games elsewhere, and Propose the following strategy

# create a branch for this
# merge, compile and unit test each one
# intermittently integration test (probably every second one, plus everything 
where there was merge conflict)
# submit as a final PR for review, with full integration tests
# ignore checkstyle issues where the code in question matches 100% trunk
# fix findbugs issues
# once yetus is happy, merge commit the branch. 

All the patches are already in trunk, so backporting individual patches doesn't 
need a vote. I'm just doing this in a way which is methodical

{code}

| Hash         | Date                      | Commit message | Author | 
Committer | 
|--------------|---------------------------|----------------|--------|-----------|
|  bd50fa956b1 | 2018-10-09 20:02:12 +0100 | HADOOP-15825. ABFS: Enable some 
tests for namespace not enabled account using OAuth. Contributed by Da Zhou. | 
Steve Loughran | Steve Loughran |              
|  ef9dc6c44c6 | 2018-10-15 22:53:55 +0100 | HADOOP-15851. Disable wildfly logs 
to the console. Contributed by Vishwajeet Dusane. | Steve Loughran | Steve 
Loughran |                                      
|  e374584479b | 2018-10-24 14:18:35 -0700 | HADOOP-15823. ABFS: Stop requiring 
client ID and tenant ID for MSI (Contributed by Da Zhou via Daniel Templeton) | 
Daniel Templeton | Daniel Templeton |      
|  13f0ee21f2c | 2019-01-02 09:33:09 -0700 | HADOOP-15860. ABFS: Throw 
exception when directory / file name ends with a period (.). Contributed by 
Shweta Yakkali. | Sean Mackrory | Sean Mackrory |       
|  65f60e56b08 | 2019-02-28 14:22:32 +0000 | HADOOP-16068. ABFS Authentication 
and Delegation Token plugins to optionally be bound to specific URI of the 
store. | Steve Loughran | Steve Loughran |       
|  05df151d09b | 2019-03-05 14:02:34 +0000 | HADOOP-16163. NPE in 
setup/teardown of ITestAbfsDelegationTokens. | Da Zhou  | Steve Loughran |      
                                                         
|  bb8ad096e78 | 2019-03-09 09:55:56 -0800 | HADOOP-16157. [Clean-up] Remove 
NULL check before instanceof in AzureNativeFileSystemStore (Contributed by 
Shweta Yakkali via Daniel Templeton) | Shweta Yakka
|  ddede7ae6fb | 2019-03-09 18:45:17 +0000 | HADOOP-16174. Disable wildfly logs 
to the console. | Denes Gerencser | Steve Loughran |                            
                                           
|  1edf1914acb | 2019-03-18 13:18:08 +0000 | HADOOP-16182. Update abfs storage 
back-end with "close" flag when application is done writing to a file. | 
Vishwajeet Dusane | Steve Loughran |               
|  1cef194a280 | 2019-04-29 13:27:28 +0100 | HADOOP-16242. ABFS: add bufferpool 
to AbfsOutputStream. | Da Zhou  | Steve Loughran |                              
                                           
|  7c2d7c05a9a | 2019-05-10 12:46:03 -0700 | HADOOP-16251. ABFS: add 
FSMainOperationsBaseTest | DadanielZ | {{ git-name }} |                         
                                                      
|  5f1a34649f1 | 2019-05-10 13:55:56 -0700 | Revert "HADOOP-16251. ABFS: add 
FSMainOperationsBaseTest" | Aaron Fabbri | Aaron Fabbri |                       
                                              
|  ff27e8eabde | 2019-05-10 13:57:30 -0700 | HADOOP-16251. ABFS: add 
FSMainOperationsBaseTest. Re-commit to fix git metadata. | DadanielZ | Aaron 
Fabbri |                                                 
{code}

> Backport ABFS changes from trunk to branch-3.2
> ----------------------------------------------
>
>                 Key: HADOOP-16353
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16353
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>    Affects Versions: 3.2.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-16353-branch-3.2-001.patch
>
>
> We've been backporting abfs patches from trunk to branch-3.2, mostly, but not 
> all have made it in, mostly by errors of omission.
> Backport all of those which make sense, which is, at a glance, pretty much 
> all of them
> avoid: incompatible JAR changes etc. that is: commons-lang, mockito, and the 
> like.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to