xiaoyuyao commented on a change in pull request #937: HDDS-1663. Add datanode 
to network topology cluster during node regis…
URL: https://github.com/apache/hadoop/pull/937#discussion_r292138639
 
 

 ##########
 File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
 ##########
 @@ -372,14 +372,15 @@ public StorageContainerManager(OzoneConfiguration conf,
   private void initializeSystemManagers(OzoneConfiguration conf,
                                        SCMConfigurator configurator)
       throws IOException {
+    clusterMap = new NetworkTopologyImpl(conf);
 
 Review comment:
   We don't need to create two NetworkTopologyImpl instances. One here and one 
in SCMNodeManager. 
   Just keep one is good. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to