ChenSammi commented on a change in pull request #937: HDDS-1663. Add datanode
to network topology cluster during node regis…
URL: https://github.com/apache/hadoop/pull/937#discussion_r292265616
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
##########
@@ -945,4 +954,124 @@ public void testHandlingSCMCommandEvent()
}
}
+ /**
+ * Test add node into network topology during node register. Datanode
+ * uses Ip address to resolve network location.
+ */
+ @Test
+ public void testScmRegisterNodeWithIpAddress()
+ throws IOException, InterruptedException, AuthenticationException {
+ testScmRegisterNodeWithNetworkTopology(false);
+ }
+
+ /**
+ * Test add node into network topology during node register. Datanode
+ * uses hostname to resolve network location.
+ */
+ @Test
+ public void testScmRegisterNodeWithHostname()
+ throws IOException, InterruptedException, AuthenticationException {
+ testScmRegisterNodeWithNetworkTopology(true);
+ }
+
+ /**
+ * Test add node into a 4-layer network topology during node register.
+ */
+ @Test
+ public void testScmRegisterNodeWith4LayerNetworkTopology()
+ throws IOException, InterruptedException, AuthenticationException {
+ OzoneConfiguration conf = getConf();
+ conf.setTimeDuration(OZONE_SCM_HEARTBEAT_PROCESS_INTERVAL, 1000,
+ MILLISECONDS);
+
+ // create table mapping file
+ String[] hostNames = {"host1", "host2", "host3", "host4"};
+ String[] IpAddress = {"1.2.3.4", "2.3.4.5", "3.4.5.6", "4.5.6.7"};
+ File mapFile = File.createTempFile(getClass().getSimpleName() +
Review comment:
This will not be an issue after using the mapping file instead of creating
it on the fly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
