swagle commented on a change in pull request #846: HDDS-1555. Disable install
snapshot for ContainerStateMachine.
URL: https://github.com/apache/hadoop/pull/846#discussion_r292579310
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisClient.java
##########
@@ -167,29 +166,25 @@ public OMResponse sendCommand(OMRequest request) throws
ServiceException {
CompletableFuture<RaftClientReply> raftClientReply =
sendRequestAsync(request);
- CompletableFuture<OMResponse> omRatisResponse =
- raftClientReply.whenComplete((reply, e) -> LOG.debug(
- "received reply {} for request: cmdType={} traceID={} " +
- "exception: {}", reply, request.getCmdType(),
- request.getTraceID(), e))
- .thenApply(reply -> {
- try {
- // we need to handle RaftRetryFailure Exception
- RaftRetryFailureException raftRetryFailureException =
- reply.getRetryFailureException();
- if (raftRetryFailureException != null) {
- throw new CompletionException(raftRetryFailureException);
- }
-
- OMResponse response = OMRatisHelper
- .getOMResponseFromRaftClientReply(reply);
-
- return response;
- } catch (InvalidProtocolBufferException e) {
- throw new CompletionException(e);
- }
- });
- return omRatisResponse;
+ return raftClientReply.whenComplete((reply, e) -> LOG.debug(
+ "received reply {} for request: cmdType={} traceID={} " +
Review comment:
But it is parameterized:
LOG.debug(
"received reply {} for request: cmdType={} traceID={} " +
"exception: {}", reply, request.getCmdType(),
request.getTraceID(), e)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
