mackrorysd commented on a change in pull request #843: HADOOP-15183 S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/843#discussion_r292564647
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/MetadataStore.java
##########
@@ -169,15 +186,33 @@ void move(Collection<Path> pathsToDelete,
@RetryTranslated
void put(PathMetadata meta) throws IOException;
+ /**
+ * Saves metadata for exactly one path, potentially
+ * using any bulk operation state to eliminate duplicate work.
+ *
+ * Implementations may pre-create all the path's ancestors automatically.
+ * Implementations must update any {@code DirListingMetadata} objects which
+ * track the immediate parent of this file.
+ *
+ * @param meta the metadata to save
+ * @param operationState operational state for a bulk update
+ * @throws IOException if there is an error
+ */
+ @RetryTranslated
+ void put(PathMetadata meta,
+ @Nullable BulkOperationState BulkOperationState) throws IOException;
Review comment:
A variable with the same name as it's type - is this more Java 8 craziness I
haven't seen before? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
