steveloughran commented on a change in pull request #843: HADOOP-15183 S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/843#discussion_r292656218
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Statistic.java
##########
@@ -207,6 +209,12 @@
"S3Guard metadata store put one metadata path latency"),
S3GUARD_METADATASTORE_INITIALIZATION("s3guard_metadatastore_initialization",
"S3Guard metadata store initialization times"),
+ S3GUARD_METADATASTORE_RECORD_READS(
+ "s3guard_metadatastore_record_reads",
+ "S3Guard metadata store records read"),
+ S3GUARD_METADATASTORE_RECORD_WRITES(
+ "s3guard_metadatastore_record_writes",
+ "S3Guard metadata store records written"),
Review comment:
Good point. With the ancestor tracking the new renamer shouldn't do any more
than before. And I can verify that the commit operations don't do duplicate
puts of all the parents, the way they do currently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
