bharatviswa504 commented on a change in pull request #884: HDDS-1620. Implement
Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r292740740
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -451,6 +456,21 @@ private boolean startsWith(byte[] firstArray, byte[]
secondArray) {
public boolean isVolumeEmpty(String volume) throws IOException {
String volumePrefix = getVolumeKey(volume + OM_KEY_PREFIX);
+ if (bucketTable instanceof TypedTable) {
Review comment:
When bucketTable is not an instance of TypedTable. As only TypedTables have
Cache.
This is more like a safer check, in a case in future if someone changes the
bucketTable to RDBTable, we don't need to do the logic inside this if check.
Because cacheIterator throws NotImplementedException for RDBTable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
