steveloughran commented on issue #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries … URL: https://github.com/apache/hadoop/pull/802#issuecomment-501387227 Update, believe I've identified the problem, it's a subtle but fun one with (my suggested) change to accepting configurable times (e.g. 15m) for a TTL, the time in seconds was being passed down to a ttl class expecting millis. As a result, dir listings in the tests were going nonauth ~immediately, so the guardedFS in tests was immediately resyncing with the store. Hence: none of the expected mismatches Fixing that (one liner) with some extended OOB test looking at the internals (written during debugging) and with HADOOP-16368 *S3A list operation doesn't pick up etags from results*, as I've extended the match testing to include etags rather than just timestamps. much less brittle. I'm retaining the modtime test too, for regression rather than as the sole comparison
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
