hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in 
MapReduce.
URL: https://github.com/apache/hadoop/pull/953#issuecomment-501954516
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 36 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 12 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 63 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1126 | trunk passed |
   | +1 | compile | 1140 | trunk passed |
   | +1 | checkstyle | 155 | trunk passed |
   | +1 | mvnsite | 344 | trunk passed |
   | +1 | shadedclient | 1189 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 244 | trunk passed |
   | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 524 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 44 | Maven dependency ordering for patch |
   | +1 | mvninstall | 232 | the patch passed |
   | +1 | compile | 988 | the patch passed |
   | -1 | javac | 988 | root generated 21 new + 1474 unchanged - 0 fixed = 1495 
total (was 1474) |
   | +1 | checkstyle | 149 | root: The patch generated 0 new + 1010 unchanged - 
17 fixed = 1010 total (was 1027) |
   | +1 | mvnsite | 333 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 638 | patch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 227 | the patch passed |
   | -1 | findbugs | 84 | 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 562 | hadoop-common in the patch passed. |
   | +1 | unit | 1264 | hadoop-yarn-server-nodemanager in the patch passed. |
   | -1 | unit | 335 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | unit | 68 | hadoop-mapreduce-client-common in the patch failed. |
   | +1 | unit | 584 | hadoop-mapreduce-client-app in the patch passed. |
   | -1 | unit | 3966 | hadoop-mapreduce-client-jobclient in the patch failed. |
   | +1 | unit | 911 | hadoop-gridmix in the patch passed. |
   | -1 | asflicense | 48 | The patch generated 15 ASF License warnings. |
   | | | 15525 | |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | 
module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
 |
   |  |  Suspicious comparison of Boolean references in 
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean)  At Job.java:in 
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean)  At Job.java:[line 1507] |
   |  |  
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean) concatenates strings using + in a loop  At Job.java:using + in a 
loop  At Job.java:[line 1511] |
   |  |  Should org.apache.hadoop.mapreduce.JobResourceUploader$MRResourceInfo 
be a _static_ inner class?  At JobResourceUploader.java:inner class?  At 
JobResourceUploader.java:[lines 77-145] |
   | Failed junit tests | hadoop.mapreduce.TestJobResourceUploader |
   |   | hadoop.mapreduce.v2.util.TestMRApps |
   |   | hadoop.mapred.TestTextOutputFormat |
   |   | hadoop.mapreduce.lib.input.TestNLineInputFormat |
   |   | hadoop.mapred.TestUserDefinedCounters |
   |   | hadoop.mapred.TestMapProgress |
   |   | hadoop.mapred.TestReduceFetch |
   |   | hadoop.mapreduce.lib.map.TestMultithreadedMapper |
   |   | hadoop.mapreduce.lib.join.TestJoinDatamerge |
   |   | hadoop.mapred.lib.aggregate.TestAggregates |
   |   | hadoop.mapred.TestJobCleanup |
   |   | hadoop.mapred.TestComparators |
   |   | hadoop.fs.TestDFSIO |
   |   | hadoop.mapreduce.lib.chain.TestMapReduceChain |
   |   | hadoop.mapreduce.v2.TestMRJobsWithHistoryService |
   |   | hadoop.mapred.TestKeyValueTextInputFormat |
   |   | hadoop.mapreduce.lib.input.TestCombineFileInputFormat |
   |   | hadoop.mapred.TestLocalMRNotification |
   |   | hadoop.mapreduce.lib.db.TestDataDrivenDBInputFormat |
   |   | hadoop.mapred.TestYARNRunner |
   |   | hadoop.mapred.TestFileInputFormatPathFilter |
   |   | hadoop.mapreduce.security.TestMRCredentials |
   |   | hadoop.mapred.TestMultiFileInputFormat |
   |   | hadoop.mapred.TestMRCJCFileOutputCommitter |
   |   | hadoop.mapreduce.v2.TestMROldApiJobs |
   |   | hadoop.mapreduce.lib.input.TestMRCJCFileInputFormat |
   |   | hadoop.mapred.TestMapRed |
   |   | hadoop.mapreduce.lib.input.TestMultipleInputs |
   |   | hadoop.mapred.TestFileOutputFormat |
   |   | hadoop.mapred.lib.TestMultipleOutputs |
   |   | hadoop.mapreduce.lib.output.TestMRCJCFileOutputCommitter |
   |   | hadoop.mapred.TestSequenceFileAsBinaryOutputFormat |
   |   | hadoop.mapreduce.v2.TestMRAppWithCombiner |
   |   | hadoop.mapreduce.v2.TestUberAM |
   |   | hadoop.mapred.TestLocalJobSubmission |
   |   | hadoop.mapreduce.TestMapReduce |
   |   | hadoop.mapred.TestTaskCommit |
   |   | hadoop.mapred.TestLazyOutput |
   |   | hadoop.mapreduce.lib.input.TestLineRecordReaderJobs |
   |   | hadoop.mapreduce.lib.chain.TestChainErrors |
   |   | hadoop.mapreduce.lib.output.TestMRSequenceFileAsBinaryOutputFormat |
   |   | hadoop.mapred.TestJavaSerialization |
   |   | hadoop.ipc.TestMRCJCSocketFactory |
   |   | hadoop.conf.TestNoDefaultsJobConf |
   |   | hadoop.mapred.lib.TestLineInputFormat |
   |   | hadoop.hdfs.TestNNBench |
   |   | hadoop.mapreduce.v2.TestRMNMInfo |
   |   | hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl |
   |   | hadoop.mapred.lib.TestKeyFieldBasedComparator |
   |   | hadoop.mapreduce.lib.input.TestMRSequenceFileAsBinaryInputFormat |
   |   | hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter |
   |   | hadoop.mapreduce.security.TestBinaryTokenFile |
   |   | hadoop.mapred.lib.TestChainMapReduce |
   |   | hadoop.fs.slive.TestSlive |
   |   | hadoop.mapred.TestMiniMRClientCluster |
   |   | hadoop.mapred.TestSequenceFileAsBinaryInputFormat |
   |   | hadoop.mapred.TestOldCombinerGrouping |
   |   | hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers |
   |   | hadoop.mapred.TestMRIntermediateDataEncryption |
   |   | hadoop.mapred.TestMerge |
   |   | hadoop.mapred.join.TestDatamerge |
   |   | hadoop.mapred.TestCollect |
   |   | hadoop.mapreduce.lib.aggregate.TestMapReduceAggregates |
   |   | hadoop.mapreduce.lib.partition.TestMRKeyFieldBasedComparator |
   |   | hadoop.mapreduce.lib.chain.TestSingleElementChain |
   |   | hadoop.mapred.TestSequenceFileInputFilter |
   |   | hadoop.mapred.TestJobName |
   |   | hadoop.mapred.TestMRTimelineEventHandling |
   |   | hadoop.mapreduce.v2.TestMRJobs |
   |   | hadoop.mapred.TestMultipleTextOutputFormat |
   |   | hadoop.mapred.pipes.TestPipesNonJavaInputFormat |
   |   | hadoop.mapred.TestLineRecordReaderJobs |
   |   | hadoop.mapred.jobcontrol.TestLocalJobControl |
   |   | hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat |
   |   | hadoop.mapred.TestMROpportunisticMaps |
   |   | hadoop.mapred.TestClusterMapReduceTestCase |
   |   | hadoop.mapred.TestJobCounters |
   |   | hadoop.mapred.TestMultiFileSplit |
   |   | hadoop.mapred.TestReduceFetchFromPartialMem |
   |   | hadoop.io.TestSequenceFileMergeProgress |
   |   | hadoop.mapred.TestClusterMRNotification |
   |   | hadoop.mapreduce.TestLargeSort |
   |   | hadoop.mapreduce.v2.TestMRJobsWithProfiler |
   |   | hadoop.mapred.TestMiniMRBringup |
   |   | hadoop.mapred.TestSpecialCharactersInOutputPath |
   |   | hadoop.mapreduce.v2.TestNonExistentJob |
   |   | hadoop.mapreduce.lib.output.TestMRMultipleOutputs |
   |   | hadoop.mapreduce.TestMapReduceLazyOutput |
   |   | hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities |
   |   | hadoop.mapreduce.TestNewCombinerGrouping |
   |   | hadoop.mapred.TestNetworkedJob |
   |   | hadoop.mapred.TestMiniMRChildTask |
   |   | hadoop.mapreduce.lib.output.TestJobOutputCommitter |
   |   | hadoop.mapreduce.lib.fieldsel.TestMRFieldSelection |
   |   | hadoop.mapred.lib.TestMultithreadedMapRunner |
   |   | hadoop.mapreduce.v2.TestSpeculativeExecutionWithMRApp |
   |   | hadoop.mapred.TestSequenceFileInputFormat |
   |   | hadoop.mapred.TestMapOutputType |
   |   | hadoop.mapred.TestSequenceFileAsTextInputFormat |
   |   | hadoop.mapreduce.v2.TestMiniMRProxyUser |
   |   | hadoop.mapred.TestMiniMRClasspath |
   |   | hadoop.mapred.jobcontrol.TestJobControl |
   |   | hadoop.mapred.TestFieldSelection |
   |   | hadoop.fs.TestFileSystem |
   |   | hadoop.mapred.TestJobSysDirWithDFS |
   |   | hadoop.mapreduce.v2.TestSpeculativeExecution |
   |   | hadoop.mapred.TestReporter |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/953 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 14377fceeeed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 89acbbc |
   | Default Java | 1.8.0_212 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/diff-compile-javac-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-common.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/testReport/ |
   | asflicense | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/artifact/out/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 1573 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-tools/hadoop-gridmix U: . |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/5/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to