[ 
https://issues.apache.org/jira/browse/HADOOP-16374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865104#comment-16865104
 ] 

Steve Loughran commented on HADOOP-16374:
-----------------------------------------

That early cleanup guarantees that even if the process is killed during the 
wait, cleanup will happen

I'd prefer retaining the two calls, but having some state tracker which knows 
not to do the second in shutdown (or just remove the hook)

> Fix DistCp#cleanup called twice unnecessarily
> ---------------------------------------------
>
>                 Key: HADOOP-16374
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16374
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Minor
>         Attachments: HADOOP-16374-001.patch
>
>
> DistCp#cleanup called twice unnecessarily - one at finally clause insideĀ 
> createAndSubmitJob and another by Cleanup thread invoked by ShutDownHook.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to