anuengineer commented on a change in pull request #981: HDDS-1696. RocksDB use
separate Write-ahead-log location for OM RocksDB.
URL: https://github.com/apache/hadoop/pull/981#discussion_r294543691
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/utils/db/TestDBStoreBuilder.java
##########
@@ -71,12 +71,26 @@ public void builderWithOneParamV2() throws IOException {
if(!newFolder.exists()) {
Assert.assertTrue(newFolder.mkdirs());
}
- thrown.expect(IOException.class);
DBStoreBuilder.newBuilder(conf)
.setPath(newFolder.toPath())
.build();
}
+ @Test
+ public void builderWithWalDirSet() throws IOException {
+ Configuration conf = new Configuration();
+ File newFolder = folder.newFolder();
+ File walDir = folder.newFolder();
+ if(!newFolder.exists()) {
+ Assert.assertTrue(newFolder.mkdirs());
+ }
+ DBStoreBuilder.newBuilder(conf)
+ .setPath(newFolder.toPath())
Review comment:
This test illustrates my concern. We will add this feature for performance
reasons but we really have no data to show or prove this is the root cause of
perf issues. Neither can we test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
