steveloughran commented on issue #951: HADOOP-15183. S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/951#issuecomment-503045141 Last little refactoring caused whitespace issues. Will fix ``` ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/InternalConstants.java:24:public class InternalConstants {:1: Utility classes should not have a public or default constructor. [HideUtilityClassConstructor] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:153: public RenameOperation(:10: More than 7 parameters (found 8). [ParameterNumber] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:399: final S3ALocatedFileStatus sourceStatus,:34: 'sourceStatus' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:438: private Path copySourceAndUpdateTracker(:16: More than 7 parameters (found 8). [ParameterNumber] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:439: final RenameTracker renameTracker,:27: 'renameTracker' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:440: final Path sourcePath,:18: 'sourcePath' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:444: final Path destPath,:18: 'destPath' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:445: final String destKey,:20: 'destKey' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:487: final RenameTracker renameTracker,:27: 'renameTracker' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:488: final List<DeleteObjectsRequest.KeyVersion> keysToDelete,:51: 'keysToDelete' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:489: final List<Path> pathsToDelete):24: 'pathsToDelete' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:541: final Path path,:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:542: final String eTag,:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:543: final String versionId,:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:544: final long len);:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:552: final S3AFileStatus fileStatus);:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:561: final FileStatus fileStatus);:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:563: /**: First sentence should end with a period. [JavadocStyle] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:633: final List<DeleteObjectsRequest.KeyVersion> keysToDelete,:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:634: final boolean deleteFakeDir,:9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RenameOperation.java:635: final List<Path> undeletedObjectsOnFailure):9: Redundant 'final' modifier. [RedundantModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/StoreContext.java:119: public StoreContext(:10: More than 7 parameters (found 17). [ParameterNumber] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java:50:import org.apache.hadoop.fs.s3a.Tristate;:8: Unused import - org.apache.hadoop.fs.s3a.Tristate. [UnusedImports] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java:525: * {@link MetadataStore#addAncestors(Path, ITtlTimeProvider, BulkOperationState)}.: Line is longer than 80 characters (found 84). [LineLength] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java:1163: clearBucketOption(unguardedConf, fsURI.getHost(), S3_METADATA_STORE_IMPL);: Line is longer than 80 characters (found 82). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/AbstractCommitTerasortIT.java:243: public void test_200_directory_deletion() throws Throwable {:15: Name 'test_200_directory_deletion' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestPartialDeleteFailures.java:74: private static final ContextAccessors contextAccessors:41: Name 'contextAccessors' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestPartialDeleteFailures.java:349: public BulkOperationState initiateBulkWrite(final BulkOperationState.OperationType operation,: Line is longer than 80 characters (found 97). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java:988: () -> ddbms.prune(PruneMode.ALL_BY_MODTIME,0));:53: ',' is not followed by whitespace. [WhitespaceAfter] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java:1169: null );:14: ')' is preceded with whitespace. [ParenPad] ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
