[ 
https://issues.apache.org/jira/browse/HADOOP-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866852#comment-16866852
 ] 

Hadoop QA commented on HADOOP-16377:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 22 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 23m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
54s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
28s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} 
|
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
24m 45s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
23s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} 
|
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
29s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} 
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
12s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. 
{color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m 
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 15m 33s{color} 
| {color:red} root generated 5 new + 1451 unchanged - 15 fixed = 1456 total 
(was 1466) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
2m 36s{color} | {color:orange} root: The patch generated 12 new + 1081 
unchanged - 30 fixed = 1093 total (was 1111) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
24s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. 
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 34s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
56s{color} | {color:red} hadoop-common-project/hadoop-common generated 1 new + 
0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 
28s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
22s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. 
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
20s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. 
{color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 
50s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}108m  8s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 21m 
33s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
14s{color} | {color:green} hadoop-yarn-applications-catalog-webapp in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
35s{color} | {color:green} hadoop-azure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 28s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m  9s{color} 
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
50s{color} | {color:green} objectstore-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 35s{color} 
| {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
58s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}313m 42s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
|  |  Private method org.apache.hadoop.log.LogLevel$Servlet.process(Logger, 
String, PrintWriter) is never called  At LogLevel.java:is never called  At 
LogLevel.java:[lines 380-393] |
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
|  |  The field name org.apache.hadoop.hdfs.server.namenode.NameNode.MetricsLog 
doesn't start with a lower case letter  In NameNode.java:start with a lower 
case letter  In NameNode.java |
| Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
|   | hadoop.hdfs.web.TestWebHdfsTimeouts |
|   | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
|   | hadoop.ozone.container.common.impl.TestHddsDispatcher |
|   | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
|   | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
|   | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClient |
|   | hadoop.ozone.client.rpc.TestBCSID |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HADOOP-16377 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12972082/HADOOP-16377-001.patch
 |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux e3a23c72fedb 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 
18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 335c1c9 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/branch-javadoc-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-mvninstall-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/diff-compile-javac-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/diff-checkstyle-root.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-mvnsite-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-findbugs-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-javadoc-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-unit-hadoop-hdds_container-service.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-tony-runtime.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/testReport/ |
| Max. process+thread count | 5579 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
 hadoop-tools/hadoop-azure hadoop-hdds/container-service 
hadoop-ozone/integration-test hadoop-ozone/objectstore-service 
hadoop-submarine/hadoop-submarine-tony-runtime U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16328/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Moving logging APIs over to slf4j
> ---------------------------------
>
>                 Key: HADOOP-16377
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16377
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: HADOOP-16377-001.patch
>
>
> As of today, there are still 50 references to log4j1
> {code}
> $ grep -r "import org.apache.commons.logging.Log;" . |wc - l
>       50
> {code}
> To achieve the goal of HADOOP-12956/HADOOP-16206, we should invest time to 
> move them to slf4j



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to