arp7 commented on a change in pull request #949: HDDS-1672. Improve locking in
OzoneManager.
URL: https://github.com/apache/hadoop/pull/949#discussion_r295938346
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2564,6 +2564,9 @@ public void createS3Bucket(String userName, String
s3BucketName)
}
metrics.incNumBucketCreates();
try {
+ metadataManager.getLock().acquireS3BucketLock(s3BucketName);
+ metadataManager.getLock().acquireVolumeLock(
Review comment:
Many of these bugs around proper releasing on failure have always been in
the codebase. However this is a good time to fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
