avijayanhwx commented on a change in pull request #987: HDDS-1685. Recon: Add
support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r296376203
##########
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##########
@@ -227,20 +227,38 @@ public void testGetKeysForContainer() {
assertEquals(blockIds.get(0L).iterator().next().getLocalID(), 103);
assertEquals(blockIds.get(1L).iterator().next().getLocalID(), 104);
- response = containerKeyService.getKeysForContainer(3L, -1);
+ response = containerKeyService.getKeysForContainer(3L, -1, "");
keyMetadataList = (Collection<KeyMetadata>) response.getEntity();
assertTrue(keyMetadataList.isEmpty());
// test if limit works as expected
- response = containerKeyService.getKeysForContainer(1L, 1);
+ response = containerKeyService.getKeysForContainer(1L, 1, "");
keyMetadataList = (Collection<KeyMetadata>) response.getEntity();
assertEquals(keyMetadataList.size(), 1);
+
+ // test if start param works as expected
+ response = containerKeyService.getKeysForContainer(
+ 1L, -1, "/sampleVol/bucketOne/key_one");
Review comment:
Are we testing all negative cases - Limit not being specified, Start key
prefix not found ? Maybe we can split this UT into multiple ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
