steveloughran commented on a change in pull request #992: HADOOP-16537 TeraSort
Job failing on S3 DirectoryStagingCommitter: destination path exists
URL: https://github.com/apache/hadoop/pull/992#discussion_r296800183
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/TestStagingDirectoryOutputCommitter.java
##########
@@ -133,4 +146,49 @@ public void testReplaceConflictResolution() throws
Exception {
verifyCompletion(mockS3);
}
+ @Test
+ public void testReplaceConflictFailsIfDestIsFile() throws Exception {
+ pathIsFile(getMockS3A(), outputPath);
+
+ getJob().getConfiguration().set(
+ FS_S3A_COMMITTER_STAGING_CONFLICT_MODE, CONFLICT_MODE_REPLACE);
+
+ intercept(PathExistsException.class,
+ InternalCommitterConstants.E_DEST_EXISTS,
+ "Expected a PathExistsException as a the destination"
Review comment:
typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
