[ https://issues.apache.org/jira/browse/HADOOP-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871832#comment-16871832 ]
Steve Loughran commented on HADOOP-16377: ----------------------------------------- Core patch LGTM; I see the jenkins results are already missing. Can you do a rebase & resubmit so I can see those results. I think this may be good to break up into individual parts before actually committing, especially looking at the Azure set which will need an azure test run before going in ( I can help there); we can have one for hdfs, yarn, submarine, all following on from hadoop-common I'm thinking here about what is best for backporting a patch which spans a lot of code...I've been backporting bits of the hadoop-aws and hadoop-azure modules, and it makes for simpler work if I could just cherrypick in a commit for a single module. This doesn't mean changes for this patch (apart from that test run, just that when it goes in we create some subtasks for this one and commit each patch with that ID) > Moving logging APIs over to slf4j > --------------------------------- > > Key: HADOOP-16377 > URL: https://issues.apache.org/jira/browse/HADOOP-16377 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Wei-Chiu Chuang > Assignee: Prabhu Joseph > Priority: Major > Attachments: HADOOP-16357-002.patch, HADOOP-16377-001.patch, > HADOOP-16377-003.patch, HADOOP-16377-004.patch, HADOOP-16377-005.patch > > > As of today, there are still 50 references to log4j1 > {code} > $ grep -r "import org.apache.commons.logging.Log;" . |wc - l > 50 > {code} > To achieve the goal of HADOOP-12956/HADOOP-16206, we should invest time to > move them to slf4j -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org