arthas-171 opened a new pull request #1021: huowang
URL: https://github.com/apache/hadoop/pull/1021
 
 
   I encountered a problem when I converted edits files from XML to binary 
using the HDFS oev command
      Usually this conversion operation will not be a problem, but my XML 
culture contains an OP_TRUNCATE operation node, in this case, the error is 
reported, the specific error is as follows. (sorry, I can only take a 
screenshot because the company environment does not allow copying code, the 
name of the file is not NameNode's default name because I backed up the edits 
file for testing).
   
![image](https://user-images.githubusercontent.com/20262356/60243523-016a7000-98eb-11e9-84c1-05b4ef2c96e6.png)
   
   The contents of the XML file are as follows
   
![image](https://user-images.githubusercontent.com/20262356/60243723-73db5000-98eb-11e9-977e-4f9ffea068ba.png)
   I found the error-reporting code and found that the blockFromXml method 
passed the entire data node instead of the subordinate BLOCK node. I think this 
was the reason. So I modified the code and recompiled it. Then I installed a 
single node Hadoop cluster and tested the HDFS oev command conversion file 
successfully. This is my first time to submit a patch. My English is not 
particularly good, I am not sure. Should the modified code be submitted in this 
way?
   
   I hope I can contribute to the community.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to