arp7 commented on a change in pull request #1016: HDDS-1672. Improve locking in
OzoneManager.
URL: https://github.com/apache/hadoop/pull/1016#discussion_r298745982
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##########
@@ -114,9 +115,11 @@ public void createBucket(OmBucketInfo bucketInfo) throws
IOException {
Preconditions.checkNotNull(bucketInfo);
String volumeName = bucketInfo.getVolumeName();
String bucketName = bucketInfo.getBucketName();
- metadataManager.getLock().acquireVolumeLock(volumeName);
- metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
+ boolean acquiredBucketLock = false;
+ metadataManager.getLock().acquireLock(VOLUME_LOCK, volumeName);
Review comment:
Looked at this further. Failure to get volume lock is fine here. It is up to
the caller to release their resources when the stack is unwound.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
