bharatviswa504 commented on a change in pull request #1025: HDDS-373. Genconf 
tool must generate ozone-site.xml with sample values
URL: https://github.com/apache/hadoop/pull/1025#discussion_r298779284
 
 

 ##########
 File path: 
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genconf/GenerateOzoneRequiredConfigurations.java
 ##########
 @@ -106,9 +109,19 @@ public static void generateConfigurations(String path) 
throws
 
     for (OzoneConfiguration.Property p : allProperties) {
       if (p.getTag() != null && p.getTag().contains("REQUIRED")) {
-        if(p.getName().equalsIgnoreCase(OzoneConfigKeys.OZONE_ENABLED)) {
+        if (p.getName().equalsIgnoreCase(OzoneConfigKeys.OZONE_ENABLED)) {
           p.setValue(String.valueOf(Boolean.TRUE));
+        } else if (p.getName().equalsIgnoreCase(
+            OzoneConfigKeys.OZONE_METADATA_DIRS)) {
+          p.setValue(System.getProperty(OzoneConsts.JAVA_TMP_DIR));
+        } else if (p.getName().equalsIgnoreCase(
 
 Review comment:
   This will be for local one node cluster?
   As when HA comes, this will not work. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to