hadoop-yetus commented on a change in pull request #1035: HDDS-1735. Create
separate unit and integration test executor dev-support script
URL: https://github.com/apache/hadoop/pull/1035#discussion_r298781321
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -15,5 +15,6 @@
# limitations under the License.
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export HADOOP_VERSION=3
-"$DIR/../../../hadoop-ozone/dist/target/ozone-*-SNAPSHOT/compose/test-all.sh"
+OZONE_VERSION=$(cat $DIR/../../pom.xml | grep "<ozone.version>" | sed
's/<[^>]*>//g'| sed 's/^[ \t]*//')
Review comment:
shellcheck:21: note: Double quote to prevent globbing and word splitting.
[SC2086]
shellcheck:21: note: Useless cat. Consider 'cmd < file | ..' or 'cmd file |
..' instead. [SC2002]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
