leosunli commented on a change in pull request #1010: HDFS-13694. Making md5 
computing being in parallel with image loading.
URL: https://github.com/apache/hadoop/pull/1010#discussion_r298799473
 
 

 ##########
 File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
 ##########
 @@ -172,13 +172,72 @@ public LoaderContext getLoaderContext() {
       return ctx;
     }
 
+    private static class DigestThread extends Thread {
 
 Review comment:
   Thank @goiri   for reviewing this patch. Its purpose is  computing file md5 
in parallel with image loading. So I think it might not be a good util to have 
in MD5FileUtils. Please correct me if I am wrong. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to