[
https://issues.apache.org/jira/browse/HADOOP-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071760#comment-13071760
]
Daryn Sharp commented on HADOOP-7447:
-------------------------------------
Just a few small issues. Re-stating the path isn't necessary, and the
exception is inconsistent with the rest of the commands.
{code}
if (!src.fs.getFileStatus(src.path).isDirectory()) {
throw new IOException(src.path.toString() + " is not a directory");
}
{code}
As formally cited, it should be:
{code}
if (!src.stat.isDirectory()) {
throw new PathIsNotDirectoryException(src.toString());
}
{code}
Otherwise, it's good to go! Good job.
> Add a warning message for FsShell -getmerge when the src path is no a
> directory
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7447
> URL: https://issues.apache.org/jira/browse/HADOOP-7447
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.20.3
> Reporter: XieXianshan
> Assignee: XieXianshan
> Attachments: HADOOP-7447, HADOOP-7447-merge.patch, HADOOP-7447.patch
>
>
> While the <src> specified for FsShell -getmerge is not a directory,the
> command does nothing and there's no any message explaining the issue.
> Furthermore,the exitCode is zero.
> $ hdfs dfs -getmerge /user/hadoop/testfile /work/tmp/testfile
> $ echo $?
> 0
> $ ls /work/tmp/testfile
> ls: cannot access /work/tmp/testfile: No such file or directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
