lokeshj1703 commented on a change in pull request #1022: HDDS-1728. Add metrics
for leader's latency in ContainerStateMachine. Contributed by Mukul Kumar Singh.
URL: https://github.com/apache/hadoop/pull/1022#discussion_r299425652
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
##########
@@ -43,14 +46,28 @@
private @Metric MutableCounterLong numBytesWrittenCount;
private @Metric MutableCounterLong numBytesCommittedCount;
+ private @Metric MutableRate transactionLatency;
+ private MutableRate[] opsLatency;
+ private MetricsRegistry registry = null;
+
// Failure Metrics
private @Metric MutableCounterLong numWriteStateMachineFails;
private @Metric MutableCounterLong numQueryStateMachineFails;
private @Metric MutableCounterLong numApplyTransactionFails;
private @Metric MutableCounterLong numReadStateMachineFails;
private @Metric MutableCounterLong numReadStateMachineMissCount;
+ private @Metric MutableCounterLong numStartTransactionVerifyFailures;
+ private @Metric MutableCounterLong numContainerNotOpenVerifyFailures;
public CSMMetrics() {
+ int numEnumEntries = ContainerProtos.Type.values().length;
+ this.opsLatency = new MutableRate[numEnumEntries];
+ this.registry = new MetricsRegistry("CSMMetrics");
Review comment:
We can use CSMMetrics.class.getName() here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
