arp7 commented on a change in pull request #1044: HDDS-1731. Implement File
CreateFile Request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1044#discussion_r299664639
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##########
@@ -162,73 +164,88 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
KeyArgs keyArgs = createKeyRequest.getKeyArgs();
-
String volumeName = keyArgs.getVolumeName();
String bucketName = keyArgs.getBucketName();
String keyName = keyArgs.getKeyName();
OMMetrics omMetrics = ozoneManager.getMetrics();
omMetrics.incNumKeyAllocates();
- AuditLogger auditLogger = ozoneManager.getAuditLogger();
-
- Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs);
-
- OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
- OzoneManagerProtocolProtos.Type.CreateKey).setStatus(
- OzoneManagerProtocolProtos.Status.OK).setSuccess(true);
-
+ OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
+ OmKeyInfo omKeyInfo = null;
+ final List< OmKeyLocationInfo > locations = new ArrayList<>();
+ FileEncryptionInfo encryptionInfo = null;
+ IOException exception = null;
+ boolean acquireLock = false;
Review comment:
There seems to be a bug here. `acquireLock` is never set to true in any code
path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
