steveloughran commented on a change in pull request #1009: HADOOP-16383. Pass
ITtlTimeProvider instance in initialize method in …
URL: https://github.com/apache/hadoop/pull/1009#discussion_r299972677
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java
##########
@@ -377,11 +377,12 @@ private DynamoDB createDynamoDB(
* FS via {@link S3AFileSystem#shareCredentials(String)}; this will
* increment the reference counter of these credentials.
* @param fs {@code S3AFileSystem} associated with the MetadataStore
+ * @param ttlTimeProvider
* @throws IOException on a failure
*/
@Override
@Retries.OnceRaw
- public void initialize(FileSystem fs) throws IOException {
+ public void initialize(FileSystem fs, ITtlTimeProvider ttlTimeProvider)
throws IOException {
Review comment:
OK. Just be aware, I consider it transient.
@mackrorysd -as to why the context changes: it includes the metastore, so
once that is created things changed. But yes, everything in init is brittle;
including stuff like setting up delegation tokens (needed before you make any
S3 calls)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
