mukul1987 commented on a change in pull request #1047: HDDS-1750. Add block
allocation metrics for pipelines in SCM
URL: https://github.com/apache/hadoop/pull/1047#discussion_r300928623
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -152,6 +152,7 @@ public synchronized Pipeline createPipeline(
stateManager.addPipeline(pipeline);
nodeManager.addPipeline(pipeline);
metrics.incNumPipelineCreated();
+ metrics.createNumBlocksAllocatedMetric(pipeline);
Review comment:
Can line 154 and 155 be done in one state to pipelineMetrics ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
