hadoop-yetus commented on issue #1003: HADOOP-16384: Avoid inconsistencies between DDB and S3 URL: https://github.com/apache/hadoop/pull/1003#issuecomment-509790325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 31 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 15 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 62 | Maven dependency ordering for branch | | +1 | mvninstall | 1055 | trunk passed | | +1 | compile | 1045 | trunk passed | | +1 | checkstyle | 147 | trunk passed | | +1 | mvnsite | 133 | trunk passed | | +1 | shadedclient | 1009 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 107 | trunk passed | | 0 | spotbugs | 69 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 185 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for patch | | +1 | mvninstall | 78 | the patch passed | | +1 | compile | 1010 | the patch passed | | +1 | javac | 1010 | root generated 0 new + 1475 unchanged - 2 fixed = 1475 total (was 1477) | | -0 | checkstyle | 148 | root: The patch generated 33 new + 66 unchanged - 2 fixed = 99 total (was 68) | | +1 | mvnsite | 121 | the patch passed | | -1 | whitespace | 0 | The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | -1 | whitespace | 0 | The patch 5 line(s) with tabs. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedclient | 694 | patch has no errors when building and testing our client artifacts. | | -1 | javadoc | 35 | hadoop-tools_hadoop-aws generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | -1 | findbugs | 73 | hadoop-tools/hadoop-aws generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 544 | hadoop-common in the patch passed. | | +1 | unit | 286 | hadoop-aws in the patch passed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 7059 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-tools/hadoop-aws | | | Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.fs.s3a.s3guard.DumpS3GuardTable.execute() At DumpS3GuardTable.java:ignored in org.apache.hadoop.fs.s3a.s3guard.DumpS3GuardTable.execute() At DumpS3GuardTable.java:[line 176] | | | Possible null pointer dereference of actual in org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore$AncestorState.close() Dereferenced at DynamoDBMetadataStore.java:actual in org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore$AncestorState.close() Dereferenced at DynamoDBMetadataStore.java:[line 2626] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1003 | | JIRA Issue | HADOOP-16384 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 5f4ecef1f2b0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 96d0555 | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/whitespace-tabs.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/testReport/ | | Max. process+thread count | 1449 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1003/14/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
