supratimdeka commented on a change in pull request #1051: HDDS-1748. Error
message for 3 way commit failure is not verbose. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1051#discussion_r301875197
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -356,9 +356,16 @@ private void watchForCommit(boolean bufferFull) throws
IOException {
if (reply != null) {
List<DatanodeDetails> dnList = reply.getDatanodes();
if (!dnList.isEmpty()) {
- if (failedServers.isEmpty()) {
- failedServers = new ArrayList<>();
- }
+ Pipeline pipe = xceiverClient.getPipeline();
+
+ StringBuilder err = new StringBuilder();
+ err.append("Failed to commit BlockId ").append(blockID);
+ err.append(" on Pipeline ").append(pipe);
+
+ err.append(" failed nodes: ");
Review comment:
can I pass the list of DatanodeDetails directly to Log? let me check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
