[
https://issues.apache.org/jira/browse/HADOOP-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881754#comment-16881754
]
Masatake Iwasaki commented on HADOOP-16418:
-------------------------------------------
Thanks for the patch, [~xkrogen]. I applied 002 and ran findbugs on my local.
Just 1 findbugs warning is left.
{noformat}
$ cd hadoop-tools/hadoop-dynamometer
$ mvn clean compile findbugs:findbugs
$ find -name findbugsXml.xml | xargs -n 1
/opt/findbugs-3.0.0/bin/convertXmlToText
H C SA: Self assignment of field BlockInfo.replication in new
org.apache.hadoop.tools.dynamometer.blockgenerator.BlockInfo(BlockInfo) At
BlockInfo.java:[line 78]
{noformat}
{quote}The other 5 checkstyle warnings outstanding all originate from a single
Javadoc comment that has some XML tags in it. They're wrapped inside <pre> and
@code but checkstyle complains regardless.
{quote}
Setting
[checkHtml|https://checkstyle.sourceforge.io/config_javadoc.html#JavadocStyle_Properties]
to false in hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
might work while it affects all sub-projects. I think it would be ok to ignore
these warnings here.
> Fix checkstyle and findbugs warnings in hadoop-dynamometer
> ----------------------------------------------------------
>
> Key: HADOOP-16418
> URL: https://issues.apache.org/jira/browse/HADOOP-16418
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Masatake Iwasaki
> Assignee: Erik Krogen
> Priority: Minor
> Attachments: HADOOP-16418.000.patch, HADOOP-16418.001.patch,
> HADOOP-16418.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
