steveloughran commented on a change in pull request #1003: HADOOP-16384: Avoid
inconsistencies between DDB and S3
URL: https://github.com/apache/hadoop/pull/1003#discussion_r302151422
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java
##########
@@ -538,7 +538,7 @@ public CompleteMultipartUploadResult commitUpload(
public BulkOperationState initiateCommitOperation(
Path path) throws IOException {
return S3Guard.initiateBulkWrite(owner.getMetadataStore(),
- BulkOperationState.OperationType.Put, path);
Review comment:
I hadn't defined the commit type, I'd just had a "Put". Now I've added that
and an Fsck. It's useful when you log the s3guard.Operations log (Try it!)
because we log the bulk operation Id and type as well as DDB
PUT/DELETE/TOMBSTONE operations. Worth doing if you want to see what's being
done to a table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
