nandakumar131 commented on a change in pull request #1008: HDDS-1713.
ReplicationManager fail to find proper node topology based…
URL: https://github.com/apache/hadoop/pull/1008#discussion_r302535095
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeHeartbeatDispatcher.java
##########
@@ -99,6 +99,9 @@ public SCMDatanodeHeartbeatDispatcher(NodeManager
nodeManager,
commands = nodeManager.getCommandQueue(dnID);
} else {
+ // Get the datanode details again from node manager with the topology
info
+ // for registered datanodes.
+ datanodeDetails = nodeManager.getNode(datanodeDetails.getIpAddress());
Review comment:
We should not rely on the IP address of datanode in NetworkTopology path,
instead we should use the datanode UUID. It is possible that more than one
datanode process is running on the same machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
