hadoop-yetus commented on a change in pull request #1074: HDDS-1544. Support
default Acls for volume, bucket, keys and prefix. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/1074#discussion_r302796193
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -2279,7 +2332,42 @@ public void testNativeAclsForKey() throws Exception {
.setStoreType(OzoneObj.StoreType.OZONE)
.build();
- validateOzoneAcl(ozObj);
+ // Validates access acls.
+ validateOzoneAccessAcl(ozObj);
+
+ // Check default acls inherited from bucket.
+ OzoneObj buckObj = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setKeyName(key1)
+ .setResType(OzoneObj.ResourceType.BUCKET)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+
+ validateDefaultAcls(buckObj, ozObj, null, bucket);
+
+ // Check default acls inherited from prefix.
+ OzoneObj prefixObj = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setKeyName(key1)
+ .setPrefixName("dir1/")
+ .setResType(OzoneObj.ResourceType.PREFIX)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+ store.setAcl(prefixObj, getAclList(new OzoneConfiguration()));
+ // Prefix should inherit DEFAULT acl from bucket.
+
+ List<OzoneAcl> acls = store.getAcl(prefixObj);
+ assertTrue("Current acls:" + StringUtils.join(",", acls),
+ acls.contains(inheritedUserAcl));
+ assertTrue("Current acls:" + StringUtils.join(",", acls),
+ acls.contains(inheritedGroupAcl));
+ // Remove inherited acls from prefix.
+ assertTrue(store.removeAcl(prefixObj, inheritedUserAcl));
+ assertTrue(store.removeAcl(prefixObj, inheritedGroupAcl));
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
