ChenSammi commented on a change in pull request #1008: HDDS-1713.
ReplicationManager fail to find proper node topology based…
URL: https://github.com/apache/hadoop/pull/1008#discussion_r302808526
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeHeartbeatDispatcher.java
##########
@@ -99,6 +99,9 @@ public SCMDatanodeHeartbeatDispatcher(NodeManager
nodeManager,
commands = nodeManager.getCommandQueue(dnID);
} else {
+ // Get the datanode details again from node manager with the topology
info
+ // for registered datanodes.
+ datanodeDetails = nodeManager.getNode(datanodeDetails.getIpAddress());
Review comment:
Property "dfs.datanode.use.datanode.hostname" is used to control whether use
IP address or hostname. Use Ip address or hostname, current exiting
hadoop/hdfs/yarn topology tools/customer mgt scripts can be reused. It would be
easy for user to adopt Ozone. @xiaoyuyao, I can take over this if you are
fully occupied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
