bgaborg commented on issue #1079: HADOOP-16380: test to show that it is the 
root directory where the "tombstone problem" can be replicated
URL: https://github.com/apache/hadoop/pull/1079#issuecomment-511416030
 
 
   Also note that 
   ```java
       // PUT child to store
       Path child = new Path(firstPath, "child");
       StoreContext ctx = fs.createStoreContext();
       String childKey = ctx.pathToKey(child);
       String rootKey = ctx.pathToKey(root);
       AmazonS3 s3 = fs.getAmazonS3ClientForTesting("LIST");
   
       createEmptyObject(fs, childKey);
   ```
   is an out of band operation by definition in your test.
   
   The test will fail even without it - commenting out
   ```java
         //createEmptyObject(fs, childKey);
   ```
   and the check for it:
   ```java
         // the listing has the firstDir path as a prefix, because of the child
         //Assertions.assertThat(listing.getCommonPrefixes())
         //    .describedAs("The prefixes of a LIST of %s", root)
          //   .contains(firstDir + "/");
   ```
   
   Why do you add a child object to the store?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to