bharatviswa504 commented on a change in pull request #1100: HDDS-1802. Add
Eviction policy for table cache.
URL: https://github.com/apache/hadoop/pull/1100#discussion_r303694634
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCacheImpl.java
##########
@@ -70,7 +77,10 @@ public void put(CACHEKEY cacheKey, CACHEVALUE value) {
@Override
public void cleanup(long epoch) {
- executorService.submit(() -> evictCache(epoch));
+ // If it is never do nothing.
Review comment:
It is caller responsibility to call this method after the flush. And right
now this is called only after flushing to DB from OzoneManagerDoubleBuffer.
So, if it is NEVER, we will not do the cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
